From fc4603c07872be5dad3bf0f777de0552f89a0f12 Mon Sep 17 00:00:00 2001 From: Kjell Winblad Date: Tue, 12 Mar 2024 10:02:21 +0100 Subject: [PATCH 1/2] fix: redact secrets from RocketMQ debug log Fixes: https://emqx.atlassian.net/browse/EMQX-11987 --- .../emqx_bridge_rocketmq/src/emqx_bridge_rocketmq_connector.erl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/emqx_bridge_rocketmq/src/emqx_bridge_rocketmq_connector.erl b/apps/emqx_bridge_rocketmq/src/emqx_bridge_rocketmq_connector.erl index 2e7ad63c9..1af520a93 100644 --- a/apps/emqx_bridge_rocketmq/src/emqx_bridge_rocketmq_connector.erl +++ b/apps/emqx_bridge_rocketmq/src/emqx_bridge_rocketmq_connector.erl @@ -244,7 +244,7 @@ do_query( ?TRACE( "QUERY", "rocketmq_connector_received", - #{connector => InstanceId, query => Query, state => State} + #{connector => InstanceId, query => Query, state => redact(State)} ), ChannelId = get_channel_id(Query), #{ From f502ba87dfc095f75702e4b79afb33e4767f35cf Mon Sep 17 00:00:00 2001 From: Kjell Winblad Date: Tue, 12 Mar 2024 10:08:26 +0100 Subject: [PATCH 2/2] docs: add change log entry --- changes/ee/fix-12681.en.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 changes/ee/fix-12681.en.md diff --git a/changes/ee/fix-12681.en.md b/changes/ee/fix-12681.en.md new file mode 100644 index 000000000..a6b076e8e --- /dev/null +++ b/changes/ee/fix-12681.en.md @@ -0,0 +1 @@ +When sending messages to a RocketMQ bridge/action while debug level logging was activated, secrets could be emitted in debug level log messages. This has now been fixed.